feat: when pr, e2e test github actions ci #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2023 21:41
ytaek
reviewed
Sep 20, 2023
| @@ -8,17 +8,4 @@ test.describe("home", () => { | |||
| test("has title", async ({ page }) => { | |||
| await expect(page).toHaveTitle(/Githru/); | |||
| }); | |||
|
|
|||
| test("check BranchSelector", async ({ page }) => { | |||
There was a problem hiding this comment.
일주일 전 소원님이 작업하신 내용과 충돌이 발생했는데
해당 테스트 코드의 목적과 완전 달라져 삭제했습니다.
- 기존
하드코딩으로
const branchList = ['dev', 'feat', 'edit'];
- 변경(현재)
동적으로 전체 commit들의 branch 종류들을 가져와 branchList에 할당.
그래서 동적으로 데이터를 가져오기 때문에 실제 e2e test에서 결과를 정적으로 체크함에 어려움이 있었습니다. 해결책으로 모킹을 여러 방면으로 고민해봤으나 e2e test에서 함수나 컴포넌트를 모킹하는 방식은 옳은 방법이 아닌 것 같아. 방법에 더 고민이 필요해 제거했습니다!
만약 CI가 이미 있었다면 소원님이 작업하시면서 해당 내용이 failed가 떠서 당시에 바로 의논해볼 수 있었을 것 같아. 'CI가 필요했었구나!' 라는 생각이 추가로 들었습니다! 참고로 소원님이 작업해주신 방향이 맞다고 생각하고 그에 맞게 대응할 수 있는 테스트를 고민해봐야할 것 같습니다!!
Comment on lines
+19
to
+20
| - name: Setup Playwright | ||
| uses: microsoft/playwright-github-action@v1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#402
Result
Work list
Discussion