Skip to content
This repository has been archived by the owner on Nov 1, 2017. It is now read-only.

Track error codes by number and class #7

Closed
wants to merge 1 commit into from

Conversation

mheffner
Copy link
Contributor

@mheffner mheffner commented Feb 9, 2012

This removes the status code -> status name mapping and instead reports status counts by their code number (201, 404, etc). It was hard to keep track of what the string mapping names actually meant in terms of error code. It is something that should probably be handled with a display name at the graphing/presentation layer -- not in the metrics name. Also, this didn't scale well if you are interested in more codes than the mapping provided.

In addition to tracking per code, this will track per class of code: 2xx, 3xx, 4xx, etc.

@mperham
Copy link

mperham commented Aug 24, 2012

+1

@technoweenie
Copy link
Contributor

I don't know.... The problem with this is it could lead to an explosion in StatsD keys. Maybe there's just always a small, finite set of possible statuses though. Hmm.

I really want to just rip the statsd out and replace with ActiveSupport::Notifications, so it's easy to do your own thing here.

@MikeMcQuaid MikeMcQuaid closed this Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants