Cleanup #220
Cleanup #220
Conversation
| @@ -139,7 +139,7 @@ def fetch_merged_at_pull_requests | |||
| } | |||
|
|
|||
| if @options[:verbose] | |||
| puts 'Fetching merged dates... Done!' | |||
| puts "Fetching merged dates: Done!" | |||
There was a problem hiding this comment.
Thanks for cleanup! I think there is should be single quotes, since you don't use any parameters.
There was a problem hiding this comment.
I would've gone with http://viget.com/extend/just-use-double-quoted-ruby-strings and always use double quotes. But if you prefer mixed style, I can revert this part :)
There was a problem hiding this comment.
@tuexss it really makes sense. I just new in ruby, and consider, if RubyMine and rubocop pronouncedly highlight this - it should be like that "a priori". So, I thinking to move to double quote and revert this "fancy" PR :)
.. and add to rubocom.yml.
Style/StringLiterals:
EnforcedStyle: double_quotes
Thanks, for point it out!
rubocop cleanup
|
Wow! @tuexss it seems you are deeply inspect this code and fix bunch of different typos and logic issues! Now it looks much healthy! 💎 |
|
Yes, i'm also quite new in ruby. Thanks for the merge! |
I tried to add a bit of consistency and remove unused or unnecessary lines of code. I hope this helps a bit.