Fixing bug when filtering pull requests without labels #771
Conversation
|
Hi @douglasmiller ! Can you please add a test case? Thanks! |
|
Working on tests already |
douglasmiller
force-pushed
the
filter-prs
branch
from
c77222e
to
4373444
Compare
| issues | ||
| else | ||
| issues.select { |issue| issue["labels"].map { |l| l["name"] }.any? } | ||
| def filter_wo_labels(items) |
There was a problem hiding this comment.
I had to change the internals of this method beyond the initial issue of pull_request being incorrectly plural.
The original implementation, with the corrected value, would return all pull requests even when :add_pr_wo_labels was false when :add_issues_wo_labels was true. This was exposed when writing tests.
douglasmiller
force-pushed
the
filter-prs
branch
from
4373444
to
3d4ac3a
Compare
| @@ -27,6 +27,10 @@ Metrics/ClassLength: | |||
| Metrics/MethodLength: | |||
| Enabled: false | |||
|
|
|||
| Metrics/ModuleLength: | |||
There was a problem hiding this comment.
I disabled this cop for all specs instead of the per-spec solution that was used previously. Let me know if this is not desirable.
ferrarimarco
requested review from
hunner,
ferrarimarco,
olleolleolle and
skywinder
There was a problem hiding this comment.
Thanks for taking the time to improve the tests - while also fixing the defect!
This looks just right, @douglasmiller - thanks, again!
LGTM!
The
filter_wo_labelsmethod is excluding pull requests that do not have labels even though the:add_pr_wo_labels/pr-wo-labelsoption is set to true.This is due to an incorrect key being used to identify that the object being considered is a pull request.