Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restoring tag hash references to string keys #937

Merged
merged 1 commit into from Feb 19, 2021
Merged

Restoring tag hash references to string keys #937

merged 1 commit into from Feb 19, 2021

Conversation

douglasmiller
Copy link
Contributor

Fixing issue that I created in another pull request.

I changed how the tag hash's keys were being references from strings to symbols. I made the change solely for testing purposes and the convenience of using symbols.

@olleolleolle
Copy link
Collaborator

@douglasmiller Thanks a lot, that made it work!

Fetching events for issues and PR: 465
Fetching closed dates for issues: 465/465
Associating PRs with tags: 314/314
Generating entry...
Done!
Generated log placed in /Users/olle/opensource/github-changelog-generator/CHANGELOG.md

olleolleolle
olleolleolle approved these changes Feb 19, 2021
View reviewed changes
Copy link
Collaborator

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

♥️ 💛 💚 💙 💜

@olleolleolle olleolleolle merged commit f232b0e into github-changelog-generator:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@douglasmiller @olleolleolle