Rake Task: avoid calling super with arguments to avoid an ArgumentError

[olleolleolle]

Rake's RakeLib base class does not define a specific initializer.

In the initializer for our RakeTask creation class, we call super sans args.

When we do call it with a specific name, super fails like:

ArgumentError: wrong number of arguments (given 1, expected 0)
/home/travis/build/dev-sec/chef-os-hardening/vendor/bundle/ruby/2.6.0/gems/github_changelog_generator-1.16.0/lib/github_changelog_generator/task.rb:34:in `initialize'
/home/travis/build/dev-sec/chef-os-hardening/vendor/bundle/ruby/2.6.0/gems/github_changelog_generator-1.16.0/lib/github_changelog_generator/task.rb:34:in `initialize'

Fixes #942

[mfortin]

👍

[kennyadsl]

Tested this (with super()) and it works for me now.

[mfortin]

Thanks! Should I expect a new release soon ?

[olleolleolle]

Everything depends on things not going bad when releasing. If they do, I lose hope and then things take more time.

Now, I had to:

• use the invalid label and redo the changelog generation to exclude "an Issue which was not about this repo"
• due to Branch Protection, I had to spend time on making a PR, to bump version & generate changelog
• then I had to break MORE rules of Branch Protection due to other maintainers not being there
• then I could build and release to RubyGems
• And then, resetting Branch Protection

So, this is a hassle. And I've already quit this maintainership.

[olleolleolle]

@mfortin PS: the 1.16.1 is out. Try it!

[mfortin]

all good, thanks for your prompt response @olleolleolle

[kennyadsl]

Thank you @olleolleolle

[skywinder]

Thank you very much @olleolleolle 🙌

I see your pain with this. lmk, how we can we improve this.
I propose to keep release rules simple.
Probably we can remove release branch protection things? In order to make releases faster.

Btw, @mfortin @kennyadsl wants to point out that this repo needs collaborators. so if some want to participate - you are very welcome! #727

If you are using this repo, it would be great if someone can help to help to maintain and release new things for this repo.

[olleolleolle]

Updated the Settings to remove the "requires a review to be merged". All other protections remain.