Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for lint errors and a typo #1

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

parroty
Copy link
Contributor

@parroty parroty commented Jan 29, 2024

Hi πŸ‘‹ . They're very minor ones, but I just noticed them while playing with the application πŸ™‡

Typo

Instrucions to Instructions

Lint Errors

Before

$ npm run lint
/xxx/copilot-metrics-viewer/src/api/GitHubApi.ts
  23:48  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/xxx/copilot-metrics-viewer/src/components/MetricsViewer.vue
  85:71  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  88:86  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  91:57  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  94:73  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/xxx/copilot-metrics-viewer/src/components/RawDataViewer.vue
  32:29  warning  'ref' is defined but never used           @typescript-eslint/no-unused-vars
  53:33  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/xxx/copilot-metrics-viewer/src/model/Language.ts
  10:21  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

/xxx/copilot-metrics-viewer/src/model/MetricsData.ts
  10:23  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  30:23  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  37:50  warning  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

βœ– 11 problems (0 errors, 11 warnings)

After

$ npm run lint
DONE  No lint errors found!

@martedesco martedesco self-requested a review February 6, 2024 13:59
Copy link
Collaborator

@martedesco martedesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution πŸ™πŸΌ

@martedesco martedesco merged commit 33909b0 into github-copilot-resources:main Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants