Skip to content
This repository has been archived by the owner on Feb 5, 2018. It is now read-only.

Use to_json instead of hand written JSON strings for specs, and fix Webmock error. #99

Merged

Conversation

tarebyte
Copy link
Member

This PR addresses two issues.

  • Webmock was updated and validates the response body. A Hash is not listed valid parameter (see Error on invalid body bblimke/webmock#427)
  • Handwriting json objects as strings is pretty cumbersome and not very readable. Let to_json do the work for us, so that we can just make a hash

This was partially extracted from #95

afeld added a commit that referenced this pull request Nov 21, 2014
Use to_json instead of hand written JSON strings for specs, and fix Webmock error.
@afeld afeld merged commit fa6b00a into github-education-resources:master Nov 21, 2014
@afeld
Copy link
Contributor

afeld commented Nov 21, 2014

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants