Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA still not working on Unity 2018.2.11f1 with .NET 4.x #940

Closed
DevCas1 opened this issue Oct 11, 2018 · 7 comments
Closed

2FA still not working on Unity 2018.2.11f1 with .NET 4.x #940

DevCas1 opened this issue Oct 11, 2018 · 7 comments
Labels

Comments

@DevCas1
Copy link

DevCas1 commented Oct 11, 2018

Prerequisites

  • Be sure to run with tracing enabled to capture runtime details in the log file
  • Include the log file in the PR.
    • On Windows, the extension log file is at %LOCALAPPDATA%\GitHubUnity\github-unity.log
    • On macOS, the extension log file is at ~/Library/Logs/GitHubUnity/github-unity.log

Description

When logging in, GitHub for Unity asks me for a 2FA code, which dutifully arrives by SMS on my phone. When I enter the code, though, it says 'Login failed', just like with the previous release (1.0.3 - something with robots)...
Hoped updating to the newest release would fix this, but it seems like it didn't...

Steps to Reproduce

  1. Import GitHub for Unity in a blank project in Unity 2018.2.11f1 with the .NET 4.x runtime and IL2CPP set
  2. Try to login to GitHub in the GitHub window
  3. Witness that beautiful error

Expected behavior: GitHub for Unity to login to my account after entering the 2FA code that arrives on my phone (not though any authentication app, like it says it will)

Actual behavior: It gives a 'Login failed' error

Reproduces how often: All the time (except for when it's done in an empty project with .NET 3.5

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

@StanleyGoldman
Copy link
Member

Hey @DevCas1 thanks for testing this out again.
Good news is it's not stuck at the same place as last time. 😆 😞

@DevCas1
Copy link
Author

DevCas1 commented Oct 11, 2018

Anything I can help with? Be glad to help!

@StanleyGoldman
Copy link
Member

Hey @DevCas1 if you would like to start debugging the issue, that would be great. I'm busy working on #2 at the moment. If you come up with some details I can definitely coach you through fixing it.

(I'm also not above bribery and I have a swag account)

@DevCas1
Copy link
Author

DevCas1 commented Oct 17, 2018

Hey @StanleyGoldman I'd love to have a look at what's going on with the issue, but am not quite sure where to begin, or how to actually debug this stuff. Any suggestions on how to get started with debugging?

@StanleyGoldman
Copy link
Member

Hey @DevCas1 sorry I've left you hanging for so long. Are you still having this problem?

@DevCas1
Copy link
Author

DevCas1 commented Jan 9, 2019

Hey @StanleyGoldman I've made a new repo, tried the version currently in the store (version 1.1.1), and everything works just as it should!
Perhaps it's something with that perticular repo, perhaps it was the version of Unity (currently use 2018.3.0f2), but everything works fine now!
I'll close this issue, because for me it does not exist anymore. If I do run into it again, I'll try to look into it more actively. Can't be that I'm the only one who has this issue.

@DevCas1 DevCas1 closed this as completed Jan 9, 2019
@StanleyGoldman
Copy link
Member

Thanks @DevCas1. I'm happy it all worked out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants