Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Annotations break highlighting #2660

Closed
pradyunsg opened this issue Oct 1, 2015 · 5 comments
Closed

Python 3 Annotations break highlighting #2660

pradyunsg opened this issue Oct 1, 2015 · 5 comments

Comments

@pradyunsg
Copy link

Currently, if the Python code contains function-annotations (new in Python 3), the highlighting goes hay-wire (as can be seen here).

Please fix. (← there's definitely a better way to say this, but I'm sleepy :| )

@berdario
Copy link
Contributor

berdario commented Oct 2, 2015

Yeah, github is pretty nasty in this respect

I was affected by the same issue recently

linguist uses this stuff for syntax highlight:
https://github.com/github/linguist/tree/master/vendor/grammars

So this needs to be reported as a bug to language-python, which has already been done

I also tried to fix it with a PR, but the test that I added is not working...

The original author was @kevinsawicki but I'm afraid that language-python nowadays is not actively maintained anymore

@pchaigno
Copy link
Contributor

pchaigno commented Oct 2, 2015

Thanks @berdario for your answer!

To add on this, there is a fix on the way at atom/language-python#88. I just need to find the time to finish it :/

The original author was @kevinsawicki but I'm afraid that language-python nowadays is not actively maintained anymore

It can take some time but the grammar is still maintained. Look at the merged/closed PRs ;)

@berdario
Copy link
Contributor

berdario commented Oct 2, 2015

You're right... today I was a bit pessimistic upon seeing that the last merged PR is from 1 month ago.

@pchaigno
Copy link
Contributor

pchaigno commented Oct 2, 2015

September is a busy month 😄

@bkeepers
Copy link
Contributor

bkeepers commented Oct 7, 2015

Closing this since it's being tracked in atom/language-python#68

@bkeepers bkeepers closed this as completed Oct 7, 2015
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants