Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSON is not CoffeeScript (strictly speaking) #4344

Closed
4 tasks done
Alhadis opened this issue Dec 6, 2018 · 6 comments
Closed
4 tasks done

CSON is not CoffeeScript (strictly speaking) #4344

Alhadis opened this issue Dec 6, 2018 · 6 comments

Comments

@Alhadis
Copy link
Collaborator

Alhadis commented Dec 6, 2018

Preliminary Steps

Please confirm you have...

Problem Description

I used a linguist-detectable=true override earlier tonight to mark my Alhadis/language-etc repo as CSON, not CSS. I was surprised to see the repo flagged as CoffeeScript instead.

I know it's a parent language (although should it be?), but this goes against the Principle of Least Astonishment.

URL of the affected repository:

Alhadis/language-etc@59cfb4f

Last modified on:

2018-12-06

Expected language:

CSON

Detected language:

CoffeeScript

@Alhadis Alhadis changed the title Force-enabling a file's detectable attribute should use it's parent language Force-enabling a file's detectable attribute should *not* use parent language Dec 6, 2018
@Alhadis
Copy link
Collaborator Author

Alhadis commented Dec 6, 2018

Whoops. Just realised what was wrong with the title. /facepalm'

@pchaigno
Copy link
Contributor

pchaigno commented Dec 6, 2018

Is it really the fact that the parent language is displayed that astonishes you or the fact that CSON is grouped under CoffeeScript? I'm surprised by the latter, but find the former normal. Imagine if JSON with Comments was displayed when you mark Sublime Text files to be detectable...

@Alhadis
Copy link
Collaborator Author

Alhadis commented Dec 6, 2018

Wait, no, you're goddamn right. 😥 This is another language which shouldn't be grouped under a "similar" language (like JSON and JavaScript). I believe I only connected CSON to CoffeeScript because, well... that's how JSON/JavaScript did it. 😠

@Alhadis Alhadis changed the title Force-enabling a file's detectable attribute should *not* use parent language CSON is not CoffeeScript (strictly speaking) Dec 6, 2018
@Alhadis
Copy link
Collaborator Author

Alhadis commented Dec 6, 2018

So, after making a typo in this issue's title that turned out to be correct the first time (but only after correcting and pointing it out), I feel like an idiot and am now obliged to close this with a PR. 😢

@pchaigno
Copy link
Contributor

pchaigno commented Dec 6, 2018

Closing with a PR is never a bad thing :p

@Alhadis
Copy link
Collaborator Author

Alhadis commented Dec 6, 2018

BTW:

Imagine if JSON with Comments was displayed when you mark Sublime Text files to be detectable...

That reminded me that doing so would result in JSON files classified as JavaScript. Which, like CSON/CoffeeScript, isn't... really accurate. I'll fix both. 👍

Alhadis added a commit that referenced this issue Dec 6, 2018
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants