-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSON is not CoffeeScript (strictly speaking) #4344
Comments
Whoops. Just realised what was wrong with the title. |
Is it really the fact that the parent language is displayed that astonishes you or the fact that CSON is grouped under CoffeeScript? I'm surprised by the latter, but find the former normal. Imagine if |
Wait, no, you're goddamn right. 😥 This is another language which shouldn't be grouped under a "similar" language (like JSON and JavaScript). I believe I only connected CSON to CoffeeScript because, well... that's how JSON/JavaScript did it. 😠 |
So, after making a typo in this issue's title that turned out to be correct the first time (but only after correcting and pointing it out), I feel like an idiot and am now obliged to close this with a PR. 😢 |
Closing with a PR is never a bad thing :p |
BTW:
That reminded me that doing so would result in JSON files classified as JavaScript. Which, like CSON/CoffeeScript, isn't... really accurate. I'll fix both. 👍 |
Preliminary Steps
Please confirm you have...
Problem Description
I used a
linguist-detectable=true
override earlier tonight to mark myAlhadis/language-etc
repo as CSON, not CSS. I was surprised to see the repo flagged as CoffeeScript instead.I know it's a parent language (although should it be?), but this goes against the Principle of Least Astonishment.
URL of the affected repository:
Alhadis/language-etc@59cfb4f
Last modified on:
2018-12-06
Expected language:
CSON
Detected language:
CoffeeScript
The text was updated successfully, but these errors were encountered: