Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the GDScript language #1529

Merged
merged 2 commits into from Sep 15, 2014
Merged

Add support for the GDScript language #1529

merged 2 commits into from Sep 15, 2014

Conversation

fingolfin
Copy link
Contributor

References:

Some projects using it:

My motivation for adding it: To disambiguate these .gd files from GAP .gd files.

References:
* https://github.com/okamstudio/godot/wiki/gdscript
* http://www.godotengine.org/

Some projects using it:
* https://github.com/okamstudio/godot
* https://github.com/Qwertie-/Godot-games

My motivation for adding it: To disambiguate these .gd
files from GAP .gd files.
@pchaigno
Copy link
Contributor

The Travis build fails because the Bayesian classifier doesn't have the values for GDScript.
Try to regenerate the samples: bundle exec rake samples

@fingolfin
Copy link
Contributor Author

Done. I thought I read somewhere that I should not commit the sample.json file, to avoid merge conflicts, hence I left it out (but I did regenerate it locally and also run the tests).

@pchaigno
Copy link
Contributor

That was probably me.
I usually recommend to not commit the samples.json when possible.

@fingolfin
Copy link
Contributor Author

Hm, I wonder why samples.json is in the repository at all, then -- isn't it normally "best practice" to avoid committing generated files (for multiple reasons, one of them being the wish to avoid silly merge issues)? That would require people using the linguist repo to run bundle exec rake samples manually, but that wouldn't be too hard, would it? In other projects, I would probably have a build rule in my Makefile for it anyway, so that I (and others) never can forget to regenerate it. That said, I am not very familiar with ruby resp. Rakefiles, and I guess you have your reasons... just wondering... :)

@pchaigno
Copy link
Contributor

@fingolfin Good question...
@arfon @bkeepers Do you know why the samples.json file is not in .gitignore as @fingolfin suggested?

@bkeepers
Copy link
Contributor

That's a great question. @tnm do you know?

I don't know enough of the history on this project to say if there's a reason to have it committed.

@arfon
Copy link
Contributor

arfon commented Sep 15, 2014

The Bayesian classifier needs it!

@arfon
Copy link
Contributor

arfon commented Sep 15, 2014

The Bayesian classifier needs it!

Oops, my bad for reading this on my phone and not seeing the earlier context.

FWIW I agree this flow is less-than-optimal right now. Perhaps we should just add a bundle exec rake samples to the .travis.yml file to ensure that builds don't fail because of outdated samples?

@arfon
Copy link
Contributor

arfon commented Sep 15, 2014

BTW this PR goes some way to improving this situation.

arfon added a commit that referenced this pull request Sep 15, 2014
Add support for the GDScript language
@arfon arfon merged commit 1829b38 into github-linguist:master Sep 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants