Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More CMake samples #1978

Merged
merged 3 commits into from
Jan 9, 2015
Merged

More CMake samples #1978

merged 3 commits into from
Jan 9, 2015

Conversation

larsbrinkhoff
Copy link
Contributor

Fixes #1961 by adding six more CMake samples.

@larsbrinkhoff
Copy link
Contributor Author

Cherry-picked @pchaigno's sample from #1944.

This was referenced Jan 9, 2015
Merged
Closed
@aroben
Copy link
Contributor

aroben commented Jan 9, 2015

Should any of the new samples have a .txt extension? (Does that even matter?)

@larsbrinkhoff
Copy link
Contributor Author

I don't think it matters to the Bayesian classifier.

If it were needed, we also need to add .txt as a CMake extension. But that would seem wrong. I believe only the CMakeLists.txt file use the .txt extension, and the other CMake files conventionally use .cmake.

@bkeepers
Copy link
Contributor

bkeepers commented Jan 9, 2015

Sweet. Did you confirm that this fixes it?

@larsbrinkhoff
Copy link
Contributor Author

@bkeepers Yes.

@bkeepers
Copy link
Contributor

bkeepers commented Jan 9, 2015

Awesome. Looks good to me! 👍

bkeepers added a commit that referenced this pull request Jan 9, 2015
@bkeepers
Merge pull request #1978 from larsbrinkhoff/cmake_samples
91779b6 
More CMake samples
@bkeepers bkeepers merged commit 91779b6 into github-linguist:master Jan 9, 2015
larsbrinkhoff referenced this pull request in pchaigno/linguist Jan 10, 2015
@pchaigno
Revert github-linguist#1438: add file extensions with multiple segments
401067f
This was referenced Jan 19, 2015
Closed
Merged
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Particular CMakeLists.txt file not detected as CMake
4 participants
@larsbrinkhoff @aroben @bkeepers @pchaigno