Handling misconecption of Ocaml and Standard ML in issue #2208 #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A pull request has already been opened at #2227. It should be merged soon. |
Yep, thanks for your effort on this @pawandeep2155. This has been resolved in #2227 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added code in heuristics.rb of lib folder.
There are few unique keywords which are present uniquely in both the languages.
Ocaml :- /->|assert|class|external|functor|match|mutable|struct|try|inherit|module|virtual/
Standard ML :- /=>|abstype|datatype|handle|infixr|nonfix|withtype|local|andalso|orelese/
I created the regular expression and matched it with the data and if keywords are present then return the language which it matched.