Add compiled graphql relay to be considered generated #4118
Conversation
lib/linguist/generated.rb
Outdated
| # | ||
| # Return true or false | ||
| def generated_graphql_relay_js? | ||
| !!name.match(/__generated__\/[_A-Za-z][_0-9A-Za-z]+\.graphql\.js$/) |
There was a problem hiding this comment.
Shouldn't we mark the whole __generated__ directory as generated?
There was a problem hiding this comment.
I was going the safer route and only marking the files (.graphql.js) I know relay-compiler is generating, but the directory name is __generated__...
If you think that marking everything within any __generated__ directory is safe, I can make the change.
There was a problem hiding this comment.
Isn't the __generated__ directory created by relay-compiler?
There was a problem hiding this comment.
I'd probably mark the whole __generated__ directory as generated, but then I don't know much about GraphQL and it looks like you have some reservations about it. Anything specific that makes you think this could be "unsafe" (i.e., not the expected user behavior)?
There was a problem hiding this comment.
That sounds good to me. In a GraphQL relay project it is definitely safe to mark all files under the __generated__ directory as generated. I'm not sure about other languages/frameworks, and if they ever would use a __generated__ directory for some other purpose... yeah probably never...
One sec will make the change
There was a problem hiding this comment.
From what I could see in the search results, it looks like it's not really used outside of GraphQL. Worst-case scenario, we'll reverse if we have users complaining :/
lib/linguist/generated.rb
Outdated
| @@ -54,6 +54,7 @@ def generated? | |||
| xcode_file? || | |||
| cocoapods? || | |||
| carthage_build? || | |||
| generated_graphql_relay_js? || | |||
There was a problem hiding this comment.
Maybe remove _js at the end of the name, now that we're marking the whole directory as generated?
Marking
.graphql.jsfiles which are generated by GraphQL relay-compiler as generated.Checklist: