-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4113 : Adds .mir to YAML #4126
Conversation
cc : @pchaigno |
The build here is failing for two possible reasons, that I can understand:
I went to the official Mirah community Github to get some examples, but all the files in their repositories have cc : @pchaigno what should I do? should I remove Updates :
|
@pchaigno I've got it confirmed that |
That file extension dates from the initial versions of Linguist (2011). It's probably fine to remove it given the usage. @lildude ? |
Oh! It has been a bug for so long 😮 |
From what I understand the first item in the list should always be the main file extension. You can see this is the case for all other file extensions as well. (Example: https://github.com/gabru-md/linguist/blob/a12ce9b736321450108cfdced365ba146a2ffbfb/lib/linguist/languages.yml#L5063) So the order should not be an issue either. Its probably because of the missing example files. Please revert .yml to the top, add .mir in an alphabetical order, and then we should be good for this one IMHO :) |
Okay. I'll do it. Wait for travis and then ping you. |
@pchaigno @lildude @RobQuistNL please review :) |
LGTM 👍 |
@pchaigno can you provide with a review please. |
Yep, but on this one, I'm waiting on an answer from you, @lildude :-) |
I'm sorry! I'll be patient. 😅
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well then, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR, welcome to Linguist and sorry it took me so long to get back to this.
Thank you! |
We can certainly use the help! |
This Pull request solves issue #4113
It adds
.mir
in YAML categoryDescription
It adds
.mir
in YAML category and this PR also contains a sample code of the extension.mir
used in LLVM projects.The sample is taken from un-official LLVM Mirror on Github.
The sample code is accompanied by LICENSE specified in the repository with the original link to source code also mentioned in comments.
Checklist:
I am associating a language with a new file extension.
I am adding a new language.
I am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am adding new or changing current functionality