Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Ruby code generated by protobuf compiler #4190

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Detect Ruby code generated by protobuf compiler #4190

merged 1 commit into from
Jul 9, 2018

Conversation

btoews
Copy link

@btoews btoews commented Jul 9, 2018

Linguist doesn't detect Ruby code generated by the protobuf compiler. This PR changes that.

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@btoews
Copy link
Author

btoews commented Jul 9, 2018

@pchaigno Thanks for the review. Should I just merge this?

@pchaigno
Copy link
Contributor

pchaigno commented Jul 9, 2018

We only require one review and a 👍 from GitHub's staff, so I guess you can :-)

@btoews btoews merged commit 1dc8e28 into github-linguist:master Jul 9, 2018
@btoews btoews deleted the ruby-generated-protobuf branch July 9, 2018 19:51
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants