Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xasm language. #4193

Closed
wants to merge 3 commits into from
Closed

Add xasm language. #4193

wants to merge 3 commits into from

Conversation

pfusik
Copy link

@pfusik pfusik commented Jul 11, 2018

I add the language "xasm".

Description

It is the assembly language of the 6502 CPU with some extensions. See https://github.com/pfusik/xasm

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

    • The extension of the new language is used in hundreds of repositories on GitHub.com.
      I expect it is used in dozens, not hundreds of GitHub repositories
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
        • I wrote hello.asx myself
      • Sample license(s): WTFPL
    • I have included a syntax highlighting grammar.
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.

dta c'Hello, world!',$9b
text_len equ *-text

run main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer sample files from "real applications" under permissive licenses. Hello worlds and very short programs are usually not a good fit since we use those files to train the Bayesian classifier.

@pchaigno
Copy link
Contributor

Thanks for the pull request @pfusik!

I expect it is used in dozens, not hundreds of GitHub repositories

That's a requirement unfortunately. I'll tag the pull request as pending popularity and we can revisit when there are hundreds of repositories.

@pfusik
Copy link
Author

pfusik commented Jul 11, 2018

I see, thanks!

@pchaigno
Copy link
Contributor

pchaigno commented Aug 4, 2018

Closing in favor of #4219. We'll monitor the popularity of the extension there.

If you have an improved search query compared to the one used in #4219, please post it here and I'll update #4219.

@pchaigno pchaigno closed this Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants