Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove depth limit in Travis CI to pass incremental statistics test #4235

Merged
merged 1 commit into from
Aug 19, 2018

Conversation

pchaigno
Copy link
Contributor

The Travis CI builds are currently failing because one of the tests, test_incremental_stats, attempts to reference an older commit even though Travis CI only retrieves the last 3 commits.

This pull request changes the Travis CI configuration to retrieve all commits, thereby fixing the builds. I haven't noticed a strong increase in build time; the time to download submodules dominates the total download time anyway.

I'm not sure this is the appropriate fix as I don't understand why it worked before... It does fix the build though :-)

Template doesn't apply.

@pchaigno pchaigno changed the title Remove depth limit in Travis CI to pass OID test Remove depth limit in Travis CI to pass incremental statistics test Aug 18, 2018
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally, this doubles the time it takes to clone the repo, but as you said this pales in comparison to the time it takes to pull all the submodules so an extra 5-8s is hardly noticeable.

@pchaigno pchaigno merged commit 47ce551 into github-linguist:master Aug 19, 2018
@pchaigno pchaigno deleted the fix-travis branch August 19, 2018 14:51
@pchaigno
Copy link
Contributor Author

And I think Travis CI has a very good connection to Github.com :-)

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants