Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Rust color #4319

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Improve Rust color #4319

merged 1 commit into from
Nov 12, 2018

Conversation

pmaddams
Copy link
Contributor

@pmaddams pmaddams commented Nov 9, 2018

The Rust color on GitHub doesn't look much like rust, and I don't see where it could have come from (not on the website or part of the logo). In fact, it looks rather pale and sickly, rather than vibrant and robust.

#a62c00 is much nicer. It resembles the red paints that have traditionally been made with iron oxide.

The Rust color on GitHub doesn't look much like rust, and I don't see where it could have come from (not on the website or part of the logo). In fact, it looks rather pale and sickly, rather than vibrant and robust.

#a62c00 is much nicer. It resembles the red paints that have traditionally been made with iron oxide.
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmaddams Thanks!

@lildude lildude merged commit 6e7fb09 into github-linguist:master Nov 12, 2018
@Alhadis
Copy link
Collaborator

Alhadis commented Nov 12, 2018

#a62c00 is much nicer.

@pmaddams Small tip for future reference: if you put a hex colour-code inside backticks, GitHub will display a preview for it:

#a62c00 is much nicer.

@subnomo
Copy link

subnomo commented Nov 13, 2018

Personally not a fan of the new color, it looks too similar to Ruby.

@0xpr03
Copy link
Contributor

0xpr03 commented Nov 13, 2018

I'm also quite against this change, it was clear cut from ruby or D, now it's something in between. I even thought I'd be at the wrong place before, please change it back.

@DoumanAsh
Copy link

That's shitty colour

@dschuessler
Copy link

I am marveled that all comments on the color representing Rust code are arguing on aesthetic grounds.

The main job of linguist – as far as I understand it – is making it easy to spot in which language a given source code is written. Thus linguist does its job best if colors stay the same.

I don't think it is important what color is chosen for Rust as long as no one ends up intuitively thinking that Rust itself is written in Scala. As this is happening with me right now I consider this change a bug and not a feature.

@0xpr03
Copy link
Contributor

0xpr03 commented Nov 13, 2018

@dschuessler that was exactly my intention when I called for changing it back.
It's just the thing everyone is used to, it's pretty well distinguishable, don't change a working system.

@ghost
Copy link

ghost commented Nov 13, 2018

That's really bad

@0xpr03 0xpr03 mentioned this pull request Nov 13, 2018
@ZhangHanDong
Copy link

I like new color.

Give it symbolic meaning: "warm blood", "fresh blood".

@zimond
Copy link

zimond commented Nov 14, 2018

Why's this happening ? The submitter is not even a rust user

@rfyiamcool
Copy link

oh, no .... I don't like new color .

o(╥﹏╥)o

@wolfstudy
Copy link

oh, no .... I don't like new color .

o(╥﹏╥)o

1 similar comment
@oatiz
Copy link

oatiz commented Nov 14, 2018

oh, no .... I don't like new color .

o(╥﹏╥)o

@VitalyAnkh
Copy link

I don't like the new color. How can you do this without the agree of the Rust community?

@VitalyAnkh
Copy link

Please change the color back.

@real-felix
Copy link

Everyone is used to the old color. BTW, gitlab is still using it. Why this change?

@lildude
Copy link
Member

lildude commented Nov 14, 2018

Ok ok ok. I hear you. I hear you. I'll revert and get a new release out and up on GitHub before GitLab has a chance to update Linguist there, yup they use it too 😉, and you all head over that way to request the same change.

Locking any further comments.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Nov 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet