Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heuristic rule for Hack .hh files #4347

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Heuristic rule for Hack .hh files #4347

merged 1 commit into from
Dec 10, 2018

Conversation

pchaigno
Copy link
Contributor

@pchaigno pchaigno commented Dec 9, 2018

This pull request adds a new heuristic rule for Hack .hh files.

Description

Fixes #4346.

Checklist:

  • I am fixing a misclassified language
    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.

@pchaigno pchaigno mentioned this pull request Dec 9, 2018
Closed
4 tasks
lildude
lildude approved these changes Dec 10, 2018
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me until such time as Hack decides they no longer want to use <?hh.

@pchaigno pchaigno merged commit 1cc86b6 into github-linguist:master Dec 10, 2018
@pchaigno pchaigno deleted the hh-heuristic branch December 10, 2018 09:32
@azjezz azjezz mentioned this pull request Dec 14, 2018
Merged
3 tasks
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not all Hack files are detected correctly
2 participants
@pchaigno @lildude