Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .bash_aliases to shell language #4381

Merged
merged 4 commits into from
Jan 31, 2019
Merged

Add .bash_aliases to shell language #4381

merged 4 commits into from
Jan 31, 2019

Conversation

wesinator
Copy link
Contributor

@wesinator wesinator commented Jan 14, 2019

Description

Add bash_aliases to Shell highlighted filenames

Checklist:

@Alhadis
Copy link
Collaborator

Alhadis commented Jan 16, 2019

👋 Hi @wesinator, thanks for your submission. This looks good; I corrected the search-result URL for you (and narrowed the results down to only include bash_aliases which don't contain hashbangs). Please be sure to link correctly next time.

I harvested some ~1062 files (out of ~16,198 results in total), most of which are unique per user. Distribution most certainly checks out.

/cc @pchaigno, @lildude

@pchaigno
Copy link
Contributor

Thanks a lot @Alhadis for running Harvester!

@wesinator Could you add a sample file as per the contribution guidelines? We prefer sample files from "real" applications (as they are used for tests and to train the Bayesian classifier) and under permissive licenses.

@Alhadis
Copy link
Collaborator

Alhadis commented Jan 16, 2019

Thanks a lot @Alhadis for running Harvester!

More like thanks for fixing Harvester. 😉

FYI, the dotted variant of the filename (.bash_aliases) also commands considerable usage. I harvested 1,850 out of ~16,198 results, which is much more than the undotted variant. We should include it as well.

github-linguist.gemspec Outdated Show resolved Hide resolved
@pchaigno
Copy link
Contributor

Should we also add bash_aliases as a filename?

lib/linguist/languages.yml Show resolved Hide resolved
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pchaigno pchaigno requested a review from lildude January 23, 2019 14:48
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lildude lildude merged commit 4aee813 into github-linguist:master Jan 31, 2019
@wesinator wesinator deleted the patch-1 branch January 31, 2019 15:49
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants