-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Cabal configuration files #4419
Conversation
@pchaigno You might want to add |
people are quite free to have different project files, and the names are definitely not consistent. e.g. I have used https://github.com/haskell-servant/servant/blob/master/cabal.ghcjs.project (note the dot, not a dash). If |
Unfortunately, it doesn't. 😞 We're currently limited to matching complete filenames only (and only as fixed strings; e.g., no regex-aware matching). This is a known limitation of Linguist, I'm afraid.
Be that as it may, it's still worth keeping an eye on if over 40 users have used this particular filename to date. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm tagging this PR as Pending Popularity to remember to add it to #4219. |
This PR adds support for Cabal config files, which are used to store metadata about Haskell projects (à la
package.json
in a JavaScript project).Description
Lack of support for Cabal was brought to my attention by @phadej in
haskell-CI/haskell-ci#223
, when I was correcting the language of some misclassified files:Syntax highlighting is already provided by our existing Haskell grammar.
Checklist:
.cabal
: ~99,110 resultscabal.config
: ~2,944 resultscabal.project
: ~2,375 resultscabal.project
: Source | BSD3 clausecabal.config
: Source | MIT-licensedline2pdf.cabal
: Source | MIT-licenseddefaults.cabal
: Generated by me usingcabal init
[1]Footnotes
[1] –
cabal init
output