Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go testdata to vendor.yml #4423

Merged
merged 3 commits into from
Apr 4, 2019
Merged

Add Go testdata to vendor.yml #4423

merged 3 commits into from
Apr 4, 2019

Conversation

fgblomqvist
Copy link
Contributor

This adds Go testdata folders to vendors.yml as per #4420.

@fgblomqvist fgblomqvist changed the title Add Go testdata to vendors.yml Add Go testdata to vendor.yml Feb 15, 2019
@fgblomqvist
Copy link
Contributor Author

I'm a little lost regarding how you want this tested. There doesn't seem to be any other tests for vendor.yml patterns (only one for README in test_blob#test_vendored?) but I put a test in there s since that's what the instructions say in vendor.yml. Lmk if the test isn't of the correct format (wasn't sure which function you want to be used, but sample_blob seemed to do the job, not requiring any empty dummy-files etc.).

@stale
Copy link

stale bot commented Mar 17, 2019

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Mar 17, 2019
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tests are generally not required for such changes (i.e., adding items to our vendored and documentation lists).

@stale stale bot removed the Stale label Mar 17, 2019
@fgblomqvist
Copy link
Contributor Author

Alright, sounds good!

@pchaigno pchaigno requested a review from lildude March 21, 2019 09:45
@lildude lildude merged commit 1c25169 into github-linguist:master Apr 4, 2019
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants