-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ssh config language #4429
add ssh config language #4429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @atakanyenel! 👍 I've pointed out some things that need fixing.
Additionally, it looks like CI is failing because of an outdated license cache. You may need to run script/licensed
locally, commit the updated licenses, and update your branch.
LGTM. 👍 @pchaigno, any input? |
Can A rework be done to catch the licence error on the local dev stage ? |
Running |
Looks great, thanks for your patience! |
Thanks for the sshconfig grammar & support 👍 great community ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments below.
Overall the filenames look ok. There might even be a couple more to add.
The file extensions, however, all have low usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like something went wrong when merging/rebasing...
grammars.yml
Outdated
vendor/grammars/zephir-sublime: | ||
- source.php.zephir | ||
- source.php.zephir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you committed changes to this file by mistake.
Sorry for the force-push, I turned the PR into a mess at one point. I respected the comments and made the push accordingly. |
Nudging @pchaigno for a follow-up on their change-request review. 😉 I could dismiss your review for you, but that would be rude... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Sorry for the delay and thanks for your patience @atakanyenel!
This PR adds the new language
SSHCONFIG
for ssh configuration files and it's respective syntax highlightingDescription
This PR is about issue #3450 . The sample code is also taken from a reply to this issue.
Checklist:
I am associating a language with a new file extension.
I am adding a new language.
I am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am updating a grammar submodule
I'm updating
vendor/grammars/language-etc
as sshconfig grammar file is committed to this repo by @Alhadis