Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssh config language #4429

Merged
merged 1 commit into from
May 10, 2019
Merged

Conversation

atakanyenel
Copy link
Contributor

This PR adds the new language SSHCONFIG for ssh configuration files and it's respective syntax highlighting

Description

This PR is about issue #3450 . The sample code is also taken from a reply to this issue.

Checklist:

I'm updating vendor/grammars/language-etc as sshconfig grammar file is committed to this repo by @Alhadis

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @atakanyenel! 👍 I've pointed out some things that need fixing.

Additionally, it looks like CI is failing because of an outdated license cache. You may need to run script/licensed locally, commit the updated licenses, and update your branch.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
samples/SSHConfig/test.ssh-config Outdated Show resolved Hide resolved
@Alhadis
Copy link
Collaborator

Alhadis commented Feb 19, 2019

LGTM. 👍 @pchaigno, any input?

@atakanyenel
Copy link
Contributor Author

Can A rework be done to catch the licence error on the local dev stage ?

@Alhadis
Copy link
Collaborator

Alhadis commented Feb 19, 2019

Running brake exec rake tests should have picked up on the stale license cache... 🤔

lib/linguist/languages.yml Outdated Show resolved Hide resolved
@Alhadis
Copy link
Collaborator

Alhadis commented Feb 20, 2019

Looks great, thanks for your patience!

@atakanyenel
Copy link
Contributor Author

Thanks for the sshconfig grammar & support 👍 great community !

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments below.

Overall the filenames look ok. There might even be a couple more to add.
The file extensions, however, all have low usage.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Show resolved Hide resolved
lib/linguist/languages.yml Show resolved Hide resolved
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something went wrong when merging/rebasing...

grammars.yml Outdated
vendor/grammars/zephir-sublime:
- source.php.zephir
- source.php.zephir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you committed changes to this file by mistake.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
@atakanyenel
Copy link
Contributor Author

Sorry for the force-push, I turned the PR into a mess at one point. I respected the comments and made the push accordingly.

@Alhadis Alhadis requested a review from pchaigno April 2, 2019 12:52
@Alhadis
Copy link
Collaborator

Alhadis commented Apr 25, 2019

Nudging @pchaigno for a follow-up on their change-request review. 😉

I could dismiss your review for you, but that would be rude...

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Sorry for the delay and thanks for your patience @atakanyenel!

@pchaigno pchaigno requested a review from lildude April 25, 2019 09:38
@lildude lildude merged commit aea4f22 into github-linguist:master May 10, 2019
@Alhadis Alhadis mentioned this pull request May 10, 2019
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants