-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Motorola 68K Grammar #4439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I left a couple comments below we'll need to adress
@pchaigno Thank you for your feedback! These problems have been fixed. |
- ".X68" | ||
tm_scope: source.m68k | ||
ace_mode: assembly_x86 | ||
language_id: 477582706 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I note you've not picked a colour for this language. That's not a problem as we'll fall back to the default of #cccccc
but I wanted to check if this is intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's part of a group so it won't get a color anyway, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh!! Of course. I completely missed that. Thanks @pchaigno
@joshumax can you please resolve the merge conflict. |
Thanks. The test failure needs to be addressed now:
|
This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
@joshumax nudge |
@lildude Whoops, looks like I missed the few messages above and it went stale. I'll push it up! |
vendor/README.md
Outdated
@@ -247,6 +247,12 @@ This is a list of grammars that Linguist selects to provide syntax highlighting | |||
- **Modula-3:** [newgrammars/m3](https://github.com/newgrammars/m3) | |||
- **Monkey:** [gingerbeardman/monkey.tmbundle](https://github.com/gingerbeardman/monkey.tmbundle) | |||
- **MoonScript:** [leafo/moonscript-tmbundle](https://github.com/leafo/moonscript-tmbundle) | |||
- **Motorola 68K Assembly:** [zerkman/language-m68k](https://github.com/zerkman/language-m68k) | |||
- **MQL4:** [mqsoft/MQL5-sublime](https://github.com/mqsoft/MQL5-sublime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line and the 4 below it are what is causing the test to fail. They need to be removed from this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my last change about what needs to be fixed so we can merge this.
@joshumax Just run |
Updated branch with the requested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI's green now, @lildude. I fixed the outdated grammar-list myself. 👍 Should be good to merge.
This commit adds Motorola 68K assembly support to linguist.
Checklist:
I am associating a language with a new file extension.
I am adding a new language.
I am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am updating a grammar submodule
I am adding new or changing current functionality