Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made '-' in font-awesome optional in vendor.yml #4440

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

Ferido07
Copy link
Contributor

Description

Added different configuration for font-awesome and bootstrap.
Added directory convention for vendor files in Java maven based directory structure.

Checklist:

  • I am adding vendor file locations to ignore.

Added different configuration for font-awesome and bootstrap.
Added director convention for vendor files in Java maven based directory structure.
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like only the font-awesome change is really needed, with a tweak.

Can you please also change the title of this PR to reflect the changes you are making... "Update vendor.yml" is too vague.

lib/linguist/vendor.yml Outdated Show resolved Hide resolved
lib/linguist/vendor.yml Outdated Show resolved Hide resolved
lib/linguist/vendor.yml Outdated Show resolved Hide resolved
lib/linguist/vendor.yml Outdated Show resolved Hide resolved
@Ferido07 Ferido07 changed the title Update vendor.yml Made '-' in font-awesome optional in vendor.yml Mar 6, 2019
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@lildude lildude merged commit 6c91e3f into github-linguist:master Apr 4, 2019
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants