Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .razor extension to HTML+Razor language #4452

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

ajaybhargavb
Copy link
Contributor

@ajaybhargavb ajaybhargavb commented Mar 8, 2019

Added .razor extension to HTML+Razor language.

Checklist:

@danroth27
Copy link

For context, the .razor extension is a new extension we are introducing in .NET Core 3.0 for Razor Components that is based on the existing .cshtml Razor format. .NET Core 3.0 is currently in preview, but we expect it to ship later this year.

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the extension:razor search query and Harvester, I counted 1032 .razor files from 469 repositories by 413 users. I think this is enough to warrant support in Linguist.

@ajaybhargavb
Copy link
Contributor Author

Ping. @pchaigno, is there a reason this hasn't been merged yet?

@pchaigno pchaigno requested a review from lildude April 4, 2019 12:04
@lildude lildude merged commit c9f648f into github-linguist:master Apr 4, 2019
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants