Split TSX from TypeScript to fix #4359 #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2019
Alhadis
requested review from
pchaigno and
lildude
and removed request for
pchaigno
|
You got conflicts Sir 🎩 |
|
TSX and TSQL happened to fall RIGHT on top of each other. 😂 What were the odds. Conflicts fixed! |
pchaigno
reviewed
May 10, 2019
lildude
approved these changes
May 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the syntax highlighting errors with TSX (TypeScript with JSX/React), as described in #4359.
Note the tests are failing because of the classifier's sudden confusion between JavaScript/TypeScript… caused by
nodebeing listed as an interpreter for both. The separation of the TSX fixtures were obviously screwing with it.Merging #4470 will fix this; I merged both of my branches locally, and the tests passed. So get #4470 looked at before tending to this. =)
Template removed as it doesn't really apply.