Improve heuristic for RUNOFF/Roff *.rno files #4513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the heuristic for differentiating RUNOFF
.rno
files from Roff. Specifically, it matches syntax specific to DSR (DIGITAL Standard Runoff), a typesetting system for VMS systems descended from the originalRUNOFF
program, and a distant cousin of Unixtroff
.Description
While digging through the source code of the InfoCom games that were unearthed recently, I noticed a handful of RUNOFF documents (like this one) that were misclassified as Roff, rather than the (even older) RUNOFF language.
I wanted to add the documents as samples to help our classifier, but the InfoCom games were published for reference and historical interest only, and as stated by the READMEs:
I know there are less licensing restrictions around adding samples than adding grammars, but I get the impression the InfoCom files are all encumbered, so I'm treating them as radioactive material.
However, I tested each of the
.rno
files I found locally, and can confirm they're now being classified correctly. You can test them yourself, if you prefer:historicalsource/checkpoint/spoiler.rno
historicalsource/checkpoint/spy.rno
historicalsource/seastalker/bay.rno
historicalsource/seastalker/german.rno
historicalsource/sorcerer/archive/code.rno
historicalsource/starcross/manual.rno
historicalsource/witness/witnes.rno
Checklist: