Update dependencies: use mini mime instead of mime type #4531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in an effort to clean up dependencies, moving linguist to mini_mime removes a second mime library from being required
lildude
requested changes
May 17, 2019
|
I'm planning a new Linguist release this week @ksolo so if you're ok with it, I'm happy to remove the version bump in this PR and include this in my release. |
|
@lildude Sorry I didn't see this earlier. Yes, please include it in the new release. Thank you! |
|
Great! Thanks @ksolo. Can you please remove the version bump from this PR and I think we're all set. |
|
@lildude done and done! Just waiting on CI now |
lildude
approved these changes
May 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of dependency clean up for gh/gh; working moving to a single mime library over having 2 installed. Linguist is the only dependency requiring
mime-types, everything else is usingmini_mime.