-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Xojo module #4542
Added Xojo module #4542
Conversation
Added Xojo module to replace incorrect VBDotNet module
👋 Hey @jimmckay, thanks for the contribution. Always good to have a dedicated grammar for highlighting! Could you point me to a screenshot of how the colouring looks in Xojo IDE? |
The build is failing because the grammars list is out-of-date: 1) Failure:
TestGrammars#test_readme_file_is_in_sync [/home/travis/build/github/linguist/test/test_grammars.rb:42]:
Grammar list is out-of-date. Run `script/list-grammars`.
--- expected
+++ actual
@@ -426,7 +426,7 @@
- **XQuery:** [wcandillon/language-jsoniq](https://github.com/wcandillon/language-jsoniq)
- **XS:** [textmate/c.tmbundle](https://github.com/textmate/c.tmbundle)
- **XSLT:** [textmate/xml.tmbundle](https://github.com/textmate/xml.tmbundle)
-- **Xojo:** [angryant0007/VBDotNetSyntax](https://github.com/angryant0007/VBDotNetSyntax)
+- **Xojo:** [jimmckay/XojoSyntaxTM](https://github.com/jimmckay/XojoSyntaxTM) Did you use the |
Looks like I pasted the wrong url in lightshow for the new syntax file. |
Erm, when you do that, could you please use markdown links to embed the URL into the text? Like this: [Here is this correct url](https://github-lightshow.…/end-of-huge-url.html) Smaller URLs are fine, but Lightshow permalinks are colossal and can make a thread very difficult to peruse in review. I've amended it for you (as well as the OP), but just a note for next time. =)
Possibly. Were you using the You can fix the build failures manually if you prefer not to run the script. It's just a simple matter of editing --- expected
+++ actual
@@ -426,7 +426,7 @@
- **XQuery:** [wcandillon/language-jsoniq](https://github.com/wcandillon/language-jsoniq)
- **XS:** [textmate/c.tmbundle](https://github.com/textmate/c.tmbundle)
- **XSLT:** [textmate/xml.tmbundle](https://github.com/textmate/xml.tmbundle)
-- **Xojo:** [angryant0007/VBDotNetSyntax](https://github.com/angryant0007/VBDotNetSyntax)
+- **Xojo:** [jimmckay/XojoSyntaxTM](https://github.com/jimmckay/XojoSyntaxTM) |
Thanks @Alhadis , I'm obviously new here. I'll be sure to use markdown in the future. |
All good! 😉 We all have to start somewhere. Thanks for your patience and contribution, and welcome to Linguist! We'll get this merged once it's been given the green light by site-staff. /cc @lildude |
Awesome! Thanks for your help! |
Added Xojo module to replace incorrect VBDotNet module
Description
Provides syntax coloring comparable to the coloring seen in the Xojo IDE
I am unsure if this qualifies as adding a language or reclassifying.
Xojo language was previously included, but only pointed at source.vbnet which may have been somewhat compatible in the past, but currently produces unsatisfactory results.
Checklist: