Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GAML file extension #4549

Merged
merged 9 commits into from
Aug 12, 2019
Merged

Add GAML file extension #4549

merged 9 commits into from
Aug 12, 2019

Conversation

RoiArthurB
Copy link
Contributor

@RoiArthurB RoiArthurB commented Jun 6, 2019

@RoiArthurB
Copy link
Contributor Author

@lildude Hi! I'm trying to find a color which is not too close to any other one. I'm sad because the one I know is detected too close to another one..
Is there a way to generate any available color?

@RoiArthurB
Copy link
Contributor Author

Ok, just found one ^^

@RoiArthurB RoiArthurB changed the title Add GAML language Add GAML file extension Jun 7, 2019
Copy link

@hqnghi88 hqnghi88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initiate gaml extension in linguist

@RoiArthurB
Copy link
Contributor Author

@pchaigno Hi !
Should I add anything more or my PR is complete? 😃

@stale
Copy link

stale bot commented Jul 13, 2019

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Jul 13, 2019
@hqnghi88
Copy link

We are reviewing this request from over the world. Please keep it open.
Thanks

@stale stale bot removed the Stale label Jul 13, 2019
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RoiArthurB! Sorry for the delay in reviewing this pull request.

Usage of the .gaml extension is a bit low according to our standards. I downloaded 2094 out of the 2558 files on GitHub and counted 173 repositories by 118 users. It might be okay though given the file extension. I'll leave that decision to @lildude.

On a different note, would you know any Sublime Text, Atom, or TextMate grammar we could use for syntax highlighting. This is optional, but it's great if you have one.

Looks good to me otherwise.

@AlexisDrogoul
Copy link

Hi @pchaigno !

Thanks for your answer. We haven't designed any Atom, Sublime or TextMate grammar for GAML yet, but being officially promoted will certainly motivate us to do so !

Cheers
Alexis

@RoiArthurB
Copy link
Contributor Author

Hello all,

I've planned to work on a Sublime grammar (and so I could work on Atom and TextMate's one). I don't have any deadline, but if it could improve the PR, I can work on it quite quickly ^^

Regards,
RoiArthurB

@RoiArthurB
Copy link
Contributor Author

Hello @lildude @pchaigno I've merged my repo with your last commit.
Everything is ready to merge on your repo now 😄

@pchaigno
Copy link
Contributor

Hm. One thing I missed: we're going to need links to the original copies of the samples you used.

@RoiArthurB
Copy link
Contributor Author

Every samples come from the official Gama documentation's tutorial : https://gama-platform.github.io/wiki/Tutorials
You also can find them (and more) on the Gama repository here : https://github.com/gama-platform/gama/tree/master/msi.gama.models/models

@pchaigno
Copy link
Contributor

Could you point to the exact files used? Searching by names, I could only find one of them and it had many different instances...

@RoiArthurB
Copy link
Contributor Author

Sure here you go :

@lildude
Copy link
Member

lildude commented Jul 18, 2019

Usage of the .gaml extension is a bit low according to our standards. I downloaded 2094 out of the 2558 files on GitHub and counted 173 repositories by 118 users. It might be okay though given the file extension. I'll leave that decision to @lildude.

Ooo, this is an interesting case that I nearly 👎 because of one org over-inflating the search results: the main developer/proponent/owner's repos for this language, https://github.com/gama-platform, attributes for well over 600 of the 2558 files: gama-platform.

Using my own script (it's nearly ready for all to use), I get these stats:

Total files found: 2558
Unique public user/repos: 147
Unique owners: 102

The slight variation from Harvester can be attributed to using different methods to obtain the info, time, and the fact search will only return 1000 results and they can vary slightly each time a search is performed - I have no idea why.

If we exclude the gama-platform org from our search, we only get ~1926 files which my script summarises as:

Total files found: 1926
Unique public user/repos: 219
Unique owners: 140

This is within the realms of "hundreds of repos", so I think we're good to include this now 👍 .

@RoiArthurB We need the links to the original source of the samples listed in the initial template. We also need you to explicitly state the license of each file. Also, do we really need that many samples? From a quick look, the basic structure and tokens for each of those files don't seem to differ much. One of the larger files is probably a good representation of the structure and tokens used by the language.

@RoiArthurB
Copy link
Contributor Author

Hi @lildude

What do you mean by "the links to the original source of the samples"? I've already linked every sample to the corresponding file in the main repo of the project, isn't it enough?
Also yes, only one of all my sample could be enough, I just wanted to be the more complete as possible, but anyone of them is a real-world usage sample (tutorial more exactly) of what a gaml file looks like.

For the license stuff, I'll let @AlexisDrogoul precise it because I'm not sure on that stuff 😄

@lildude
Copy link
Member

lildude commented Jul 18, 2019

What do you mean by "the links to the original source of the samples"? I've already linked every sample to the corresponding file in the main repo of the project, isn't it enough?

I mean put the content of your comment at #4549 (comment) into the appropriate place in the template in place of the current links. The template currently links to the files in your fork of Linguist, not the original sources.

The license info would need to go into the apt location in the template too - it appears to be GPL 3 from a quick look.

@RoiArthurB
Copy link
Contributor Author

Updated 😃

@Alhadis
Copy link
Collaborator

Alhadis commented Jul 18, 2019

The slight variation from Harvester can be attributed to using different methods to obtain the info, time, and the fact search will only return 1000 results and they can vary slightly each time a search is performed - I have no idea why.

When Harvester runs, it collects results yielded by the three different "Sort" methods:

Figure 1

Whatever determines the "Best Match" criteria ultimately impacts a third of what Harvester's able to collect. It combs all three sort methods in an effort to reach past the 1000-files-per-search limit, which only matters when there's more than 3,000 results for a search.

Using my own script (it's nearly ready for all to use), I get these stats:

Oh, thank christ. Finally, we can get some server-side support for this. 😀

@lildude
Copy link
Member

lildude commented Jul 18, 2019

Oh, thank christ. Finally, we can get some server-side support for this. 😀

Nope. It's only using the public API with normal user permissions now 😁.

@Alhadis
Copy link
Collaborator

Alhadis commented Jul 18, 2019

Erh, you mean the RESTful API? I wasn't aware open-ended searches were possible without specifying a user, org, and/or repository to search within. Was this something that changed more recently?

@lildude
Copy link
Member

lildude commented Jul 18, 2019

Erh, you mean the RESTful API?

Yup. https://developer.github.com/v3/search/#search-code

I wasn't aware open-ended searches were possible without specifying a user, org, and/or repository to search within. Was this something that changed more recently?

Not that I'm aware of. You do need to be authenticated to perform the search, but that's about it.

@Alhadis
Copy link
Collaborator

Alhadis commented Jul 18, 2019

Not that I'm aware of. You do need to be authenticated to perform the search, but that's about it.

That wasn't the case in, uh, 2016 when I first wrote the Harvester script. Just realised that was was yonks ago, so a "recent" change actually means "anything that happened in the last 3 years". 😅

@RoiArthurB
Copy link
Contributor Author

Hi everyone ! 😄
So everything is ready to merge now or should I do something else? ^^

@RoiArthurB
Copy link
Contributor Author

@lildude @pchaigno 🆙

Copy link

@agrignard agrignard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this commit being a developer of GAMA Platform and having creating this issue
gama-platform/gama-platform.github.io#61

@lildude lildude merged commit f508a5a into github-linguist:master Aug 12, 2019
@agrignard
Copy link

agrignard commented Aug 13, 2019

Great news! Thank you all for the big effort to make it happened.

@lildude
Copy link
Member

lildude commented Aug 14, 2019

There is nothing you can do yet. I need to make a new release and deploy that to GitHub.com before it'll take effect. I hope to do that this week or early next.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants