Ensure generated_html? handles single line files #4620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whilst testing for the next release of Linguist, I found one of the GitHub.com tests failed as follows:
The test is failing on a very simple
.html
file that contains:The problem is the
generated_html?
method makes a few assumptions about the number of lines in the file and doesn't consider there may only be a single line.This PR corrects that behaviour .
Checklist doesn't apply as I'm fixing a bug and we don't have a section for that 😄.