Add tests for generated_html changes in #4628 #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alhadis
reviewed
Aug 30, 2019
| @@ -0,0 +1,4 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <meta name="generator" value="Some sick tool nobody's using yet" /> | |||
There was a problem hiding this comment.
Some sick tool
You can tell an Australian wrote that. 😁 Didn't even need <html lang="en-AU">.
It's only a matter of time before I start saying "yeah nah" in my pull-requests.
Alhadis
approved these changes
Aug 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised and prevented by the bug fixed by #4628, here are the tests for the changes introduced in that PR.