Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esy.sh dependencies #4642

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Add esy.sh dependencies #4642

merged 2 commits into from
Oct 11, 2019

Conversation

Et7f3
Copy link
Contributor

@Et7f3 Et7f3 commented Sep 10, 2019

Description

This adds the esy lockfile and build dir to the vendor list.

Checklist:

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

@Alhadis
Copy link
Collaborator

Alhadis commented Oct 3, 2019

Linguist doesn't acknowledge the .lock extension, so adding .esy.lock as a vendored file is redundant. Instead, we mark such files as generated, which is handled in lib/linguist/generated.rb.

Could you give a link that explains more about _esy build directories?

@Et7f3
Copy link
Contributor Author

Et7f3 commented Oct 3, 2019

I only see composer.lock, Cargo.lock, Pipfile.lock and (Gopkg|glide)\.lock also side note.
https://github.com/github/linguist/blob/50005d6e607d956479f03e378c9c54aed03e7a6e/lib/linguist/generated.rb#L364 we have the two !! we didn't have it here https://github.com/github/linguist/blob/50005d6e607d956479f03e378c9c54aed03e7a6e/lib/linguist/generated.rb#L430

for _esy The better link I have found is https://esy.sh/docs/en/how-it-works.html#local-build-store
but it deal only with some specific folder. Maybe @andreypopp can give you more information/link because it is the main developper (2084 commits vs <113 commits for others)

Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, _esy looks good.

All we need to do now is remove the .esy.lock file from vendor.yml and move it to lib/linguist/generated.rb, like I said.

@ulrikstrid
Copy link

_esy should not be committed avd is ignored in all "official" templates.

esy.lock is a directory with a bunch of files that describes the current snapshot including overrides of some packages. When something is updated there is often a huge amount of changed files here.

lock file go in generated section so it disapear from vendor.yml
@Et7f3 Et7f3 requested a review from Alhadis October 3, 2019 23:18
@Et7f3
Copy link
Contributor Author

Et7f3 commented Oct 3, 2019

If we should add test I want to add theese one https://gist.github.com/Et7f3/c36059408ffb2f648618e798b54d1d6f

@lildude lildude merged commit 1b4993f into github-linguist:master Oct 11, 2019
@Et7f3 Et7f3 deleted the patch-1 branch October 13, 2019 02:49
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants