Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle the .mask extension #4673

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Conversation

lildude
Copy link
Member

@lildude lildude commented Oct 12, 2019

Description

As pointed out in #4641, the handling of the .mask extension can be improved as at the moment all Unity3D Asset masks, Mask (aka MaskJS) and Gentoo's portage mask files are all being classified as Mask aka MaskJS.

This PR addresses that by adding the extension to Unity3D Asset and the specific filenames to Text and then implementing an heuristic to specifically identify the Unity3D mask files. An heuristic isn't implemented for the other two languages as there is no consistent and reliable method of consistently identifying them as a particular language. It is also not necessary as we can explicitly identify the portage files by filename leaving everything else up to the classifier.

Checklist:

Fixes #4641

This is the only one that is easy to detect. The MaskJS and Gentoo .mask files are sufficiently different that the classifier should be able to easily determine the difference.
@lildude lildude merged commit 59898d6 into master Oct 23, 2019
@lildude lildude deleted the lildude/better-handle-mask branch October 23, 2019 08:27
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with "Mask" language
2 participants