Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GLSL classification #4692

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Conversation

smola
Copy link
Contributor

@smola smola commented Nov 1, 2019

Description

Checklist:

* added extensions .gs, .comp and .glslf.
  See: https://stackoverflow.com/q/6432838

* add disambiguation rule for .gs files:
  if it starts with `#version <number>`, it's GLSL.
  This seems to work for most GLSL files with few exceptions
  that are catched by the classifier.

* added sample extrude_normal.gs from kyle-piddington/ShaderTool
  (licensed under MIT):
  https://github.com/kyle-piddington/ShaderTool/blob/c753a53bde6eab942da617adab9483c945f27f51/assets/shaders/extrude_normals.gs

* added sample blend_120.glslf from gfx-rs/gfx (licensed under
  Apache 2.0):
  https://github.com/gfx-rs/gfx/blob/7b084cfbb95e3e4d1ea51e91746fc75b2efb3be3/examples/blend/shader/blend_120.glslf

* test_heuristics.rb now supports alt_name to ake a different file name
for a fixture.
@stale
Copy link

stale bot commented Dec 29, 2019

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Dec 29, 2019
@lildude lildude removed the Stale label Jan 6, 2020
@lildude lildude requested review from pchaigno and Alhadis and removed request for pchaigno and Alhadis January 23, 2020 07:37
@lildude lildude merged commit 857bbfb into github-linguist:master Jan 27, 2020
@smola smola deleted the glsl-gs-take-three branch June 5, 2020 16:07
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants