Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Perl 6 to Raku #4731

Merged

Conversation

KamilaBorowska
Copy link
Contributor

@KamilaBorowska KamilaBorowska commented Dec 3, 2019

Description

Perl 6 has changed its name to Raku.

This PR introduces new extensions that aren't really used much (most code is using .p6 or .pm6) considering the support for those was introduced a week ago. However, according to https://github.com/perl6/problem-solving/blob/master/solutions/language/Path-to-Raku.md, .raku, .rakutest and .rakumod are the new extensions, and support for those is already in main Raku implementation (see changelog https://github.com/rakudo/rakudo/releases/tag/2019.11, although worth noting this only adds .rakumod as other extensions don't require implementation change). I don't think introducing those extensions will be an issue as they unambiguously refer to Raku and shouldn't conflict with anything else.

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
  • I am changing the color associated with a language

    • I have obtained agreement from the wider language community on this color change.
      • [URL to public discussion]
      • [Optional: URL to official branding guidelines for the language]

@KamilaBorowska KamilaBorowska force-pushed the rename-perl6-to-raku branch 5 times, most recently from deb33ae to 1197b50 Compare December 4, 2019 08:07
lib/linguist/languages.yml Outdated Show resolved Hide resolved
@KamilaBorowska
Copy link
Contributor Author

KamilaBorowska commented Dec 19, 2019

I think this can be merged without adding extensions if that's the only blocker (I already removed them)?

@Alhadis
Copy link
Collaborator

Alhadis commented Dec 19, 2019

@xfix We don't merge unless a GitHub staff member has given their approval; that's just policy. 😉 In any case, changes won't take effect across the site until the next release of Linguist has been made, which generally happens roughly once a month.

@Alhadis Alhadis requested a review from lildude December 19, 2019 15:31
@KamilaBorowska
Copy link
Contributor Author

Fair enough, I wasn't sure with "Pending Popularity" label.

@pchaigno
Copy link
Contributor

Sorry, I should have explained. I'm adding that label to remember to collect usage for these extensions. This can be merged as soon as @lildude gives his 👍

Alhadis added a commit to file-icons/atom that referenced this pull request Dec 20, 2019
@lildude lildude merged commit 8c99d15 into github-linguist:master Jan 6, 2020
@pchaigno pchaigno removed their assignment Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants