Replace G-Code grammar #4778
Merged
Replace G-Code grammar #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original went MIA without warning.
Alhadis
approved these changes
Jan 23, 2020
You damn well better be glad I'm not going anywhere then. 😉 |
pchaigno
approved these changes
Jan 23, 2020
|
@lildude Glad to help! I will continue to maintain the extension and let me know if there's any suggestions! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI is currently failing because the original G-Code grammar has gone MIA as the user appears to have deleted their account and all code from GitHub.
This PR replaces the grammar with what appears to be a newer and much more actively maintained grammar from https://github.com/appliedengdesign/vscode-gcode-syntax.
The highlighting isn't identical, but given the replacement is newer and more actively maintained, I think it's probably more accurate.
Checklist:
/cc FYI @mikecentola as you are the maintainer of the grammar we're now using. This will become the grammar used to highlight G-Code files on GitHub.com when I make the next release after this PR has been merged.