Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Linqpad script extension .linq to C# #4896

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

zyonet
Copy link
Contributor

@zyonet zyonet commented Jun 20, 2020

Description

LInqPad scripts are written in C# language with some linqpad related metadata added. Linqpad scripts have extension .linq and linqpad scripts in GitHub are not properly syntax highlighted. adding .linq extension to the C# language in languages.yml will fix this.

Checklist:

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yongzhao1
Copy link
Contributor

@pchaigno Yes, it would be nice to change the grammar too to highlight the top linq query metadata. but I am not familiar with how to change the grammar. maybe it is my next todo. ;D

@lildude
Copy link
Member

lildude commented Jun 22, 2020

@yongzhao1 please update the template to link to the original source of the sample, and not your fork of Linguist. We need a record of where the file came from, not how it got into Linguist 😄

@yongzhao1
Copy link
Contributor

yongzhao1 commented Jun 22, 2020

@lildude it seems I could not change ( or how to change ;) the pull request details at this moment: the sample source code would be here after it has been merged.

@lildude
Copy link
Member

lildude commented Jun 22, 2020

it seems I could not change ( or how to change ;) the pull request details at this moment:

You should be able to edit the template by clicking the three dots in the top right corner of the comment in which you placed the template and select "Edit".

the sample source code would be here after it has been merged.

I know where it'll end up 😄 . I need to know where the file came from. Where did you get that file from? That's the link we need in the template.

@lildude
Copy link
Member

lildude commented Jun 22, 2020

Nevermind. I've found where the file comes from... it comes from a repo you own at https://github.com/zyonet/PowerLinqPadScripts/blob/master/LinqPad5/chart-process-memory.linq. I've updated the template to link to this file.

@yongzhao1
Copy link
Contributor

@lildude: thanks!

@lildude lildude merged commit 8866bb0 into github-linguist:master Jun 22, 2020
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants