Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Nim's colour #4900

Merged
merged 2 commits into from Jun 27, 2020
Merged

Change Nim's colour #4900

merged 2 commits into from Jun 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 24, 2020

Description

This PR is a follow-up to #4866 (#4871) with a different color

From #37775b to #ffc200

Checklist:

I hope this time this colour would be good enough since it was checked against the same algo as GitHub's color proximity.

@ghost
Copy link
Author

ghost commented Jun 24, 2020

For curious people - image with all colours which can be used for language colours (I picked #deb012 from this one):
Full PNG - https://github.com/Yardanico/random-stuff/blob/master/goodcolours2.png
Imgur (Imgur compresses it) - https://i.imgur.com/OmOMO3w.jpg

@pietroppeter
Copy link

Nice the matrix style rendering! I also like a lot this rendering (which shows large black blobs of invalid colors): https://github.com/PMunch/colourfinder

#ffc200 was picked from that thin line between yellow and orange.

@ghost
Copy link
Author

ghost commented Jun 25, 2020

@pietroppeter yeah, I used @PMunch's colourfinder but modified it a bit to process images in parallel with Weave and output a HSV-sorted gradient image

@pietroppeter pietroppeter mentioned this pull request Jun 25, 2020
18 tasks
Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve.

@lildude
Copy link
Member

lildude commented Jun 26, 2020

The comments on this language colour topic yesterday, and some free time, prompted me to finally do something about it. I've created https://lildude.github.io/linguist-free-colours/ and opened #4903 for feedback.

@ghost
Copy link
Author

ghost commented Jun 26, 2020

The comments on this language colour topic yesterday, and some free time, prompted me to finally do something about it. I've created https://lildude.github.io/linguist-free-colours/ and opened #4903 for feedback.

Nice, but what about this PR ? :)

@lildude
Copy link
Member

lildude commented Jun 26, 2020

Nice, but what about this PR ? :)

We normally work on the basis that one of the community maintainers will review all PRs before I put my final stamp on it and merge it.

@lildude
Copy link
Member

lildude commented Jun 26, 2020

There's also no hurry for PRs to be merged as they don't go live until I make a release, which I aim to do approximately monthly, though that can slip if other things take priority.

@dom96
Copy link
Contributor

dom96 commented Jun 26, 2020

There's also no hurry for PRs to be merged

Last time another PR got merged before us and we lost a colour, so there might be a bit of a hurry :)

@lildude lildude merged commit 9c8d6e7 into github-linguist:master Jun 27, 2020
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants