-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReScript programming language #4975
Conversation
What about #e6484f? That's the other better red we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah! You're removing all the license files in this PR 😱. Please put those back. The only license file change we should see is the addition of the license file for the grammar, which I've noted doesn't appear to have a license.
Whoops sorry! It should be fixed now! I'm still trying to find an available option for the ReScript color, there are many shades of red registered already. |
01a78f0
to
f19ec31
Compare
I've managed to find a good color match for ReScript: |
That color works for us! Thanks for figuring this out 😅 |
@lildude I think we fulfilled all missing requirements, just wondering if there's anything else left that needs to be done to push this PR further? |
Yes. We still need to identify as many of the other languages that use the As this PR stands every file on GitHub.com with a |
Is there a way we can make a two-step pass on this? First, merge the PR without extension inference (making ReScript known to GitHub and configurable through |
Unfortunately not as that would require changes to the tests to accept a language without an extension or filename which kind of defeats the purpose. If we use the search results from the more generic From a search of those files that aren't XML or ReScript, most appear to be "binaries" with the |
Thanks @ryyppy. Can you please update the template in the OP with a link to the source of the XML file and state the license for the file. Other than that, this is looking good to me. |
Great! I don't have edit rights for the thread (will need to ping the OP to do that). Will drop the information in this comment for now: Sample Source: Sample License: |
Description
This pull request adds ReScript programming language.
ReScript was born from a new syntax introduced in Reason BuckleScript 8.1.
Checklist:
.resi (I understand the lack of results for the signature files)module.resiImmutableArray.resimodule.resiImmutableArray.resi