Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ocaml from Reason interepreters #5027

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented Sep 29, 2020

It's little stretched to say ocaml is interpreter of ocaml, to say the least...

I'm using languages.yml for filetype detection of scripts in vim-polyglot and this messes things up. Nobody programming in Reason would set ocaml as interpreter

@Alhadis
Copy link
Collaborator

Alhadis commented Sep 30, 2020

Just as a side-note:

It's little stretched to say ocaml is interpreter of ocaml, to say the least...

What Linguist refers to as an "interpreter" is basically "anything that runs from #!/usr/bin/env". Oddly enough, OCaml does:

λ cat > script
#!/usr/bin/env ocaml
print_endline "Hello, world!"

λ chmod +x ./script
λ ./script
Hello, world!

This doesn't extend to transpiled forms of a language, however (like Reason/OCaml, TypeScript/JavaScript, etc).

@sheerun
Copy link
Contributor Author

sheerun commented Sep 30, 2020

I highly doubt it can interpret any reason code

@sheerun
Copy link
Contributor Author

sheerun commented Sep 30, 2020

Besides it seems linguist is using interpreters list to detect languages as well. Because reason has the same syntax as ocaml, your attempts to detect script with #!/usr/bin/env ocaml as ocaml are futile, because currently both ocaml and reason match. I think ocaml is better choice here

@Alhadis
Copy link
Collaborator

Alhadis commented Sep 30, 2020

Besides it seems linguist is using interpreters list to detect languages as well

Yes, that's correct.

@lildude lildude merged commit 841803f into github-linguist:master Oct 1, 2020
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants