Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HCL's full definition to its aliases list #5109

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Add HCL's full definition to its aliases list #5109

merged 2 commits into from
Dec 16, 2020

Conversation

Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Dec 11, 2020

Description

Self-explanatory. I recently did an off-hand search for Hashicorp in languages.yml and was surprised to see "Hashicorp Configuration Language" ostensibly absent from our list.

This was going to be a language rename, but HashiCorp refer to the format quite consistently as "HCL" throughout their documentation and codebase, so it only makes sense to follow suite.

Template removed as it doesn't apply.

@Alhadis Alhadis requested a review from lildude December 11, 2020 12:45
@lildude
Copy link
Member

lildude commented Dec 11, 2020

🤔 I'm not sure we really need this. IIRC the aliases are only a convenience there to help with identifying the language for code blocks and possibly for use in the .gitattributes file. I can't find any instances of peeps trying to do either.

@Alhadis
Copy link
Collaborator Author

Alhadis commented Dec 16, 2020

Aliases are also used by language: search queries:

I know it's long and impractical, but if somebody's told to "search GitHub for Hashicorp configuration language", they'll get nothing.

@lildude
Copy link
Member

lildude commented Dec 16, 2020

Aliases are also used by language: search queries:

Oh yes. I forgot about that.

@Alhadis Alhadis merged commit 8fc4898 into master Dec 16, 2020
@Alhadis Alhadis deleted the hcl branch December 16, 2020 11:43
@Alhadis Alhadis mentioned this pull request Jan 11, 2021
4 tasks
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants