Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand tokenizer tests #5139

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Conversation

smola
Copy link
Contributor

@smola smola commented Jan 12, 2021

Description

Not all of these cases are checking behaviors that make sense, but they should serve as better quirk documentation for the tokenizer, and help understanding the impact of tokenizer changes.

Checklist:

N/A

Not all of these cases are checking behaviors that make sense, but they
should serve as better quirk documentation for the tokenizer, and help
understanding the impact of tokenizer changes.
@smola smola requested a review from a team as a code owner January 12, 2021 18:35
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Really love the test coverage! 🙇‍♂️

Stellar work as always.

@lildude lildude merged commit 714a33a into github-linguist:master Jan 13, 2021
@smola smola deleted the tokenizer-tests branch January 14, 2021 17:59
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants