Fix Nixinova submodule issues

[am11]

Description

Nixinova submodule was manually added without using script, which results in it getting deleted from .gitmodules and grammers.yml files when other languages are added or deleted

Also added a second positional argument in script/add-grammer, to override the repository name. In this case repo name is tmLanguage and the intended name is Nixinova-tmLanguage.

Exact command used (after deinit the exiting submodule):

$ script/add-grammar https://github.com/Nixinova/tmLanguage Nixinova-tmLanguage

Fixes #5291

Checklist:

• I am updating a grammar submodule

[Nixinova]

A more descriptive title for this PR would be Add optional output folder argument to script/add-grammar.

[Alhadis]

Also added a second positional argument in script/add-grammer, to override the repository name. In this case repo name is tmLanguage and the intended name is Nixinova-tmLanguage.

Erh, why not rename your repository to nixinova-linguist-grammars instead? Or nixinova-grammars, nixinova-textmate, etc… Moreover, this would break consistency between a repository's name and its submodule's name.

[am11]

why not rename your repository to nixinova-linguist-grammars instead?

That's what I suggested to him in the original issue, twice.

A more descriptive title for this PR would be

Not really, as I mentioned in the issue and in the description, the main problem with current master branch is that when someone tries to add a new grammar, it deletes your grammar because it was not added properly using script/add-grammar script.

When we do try to add your grammar using script/add-grammar script, the first error we hit is because the sub-submodule in your repo was pointing to wrong URL which was fixed by Nixinova/NovaGrammars#2. The next issue was linguist compiler gives 10+ fatal errors which were fixed by Nixinova/NovaGrammars#4. Now the upstream PRs are merged, this PR is potentially updating the submodule to fix the repo state. So the title makes sense to me.

[Nixinova]

this would break consistency between a repository's name and its submodule's name.

Well, there aren't any other repos in this called tmLanguage so just leaving this as-is would work.

[lildude]

Thanks for this @am11. As with @Alhadis, I'm not keen on allowing peeps to break the consistency between a repository's name and its submodule name as used by Linguist as it adds unnecessary complexity when trying to track problems down.

Well, there aren't any other repos in this called tmLanguage so just leaving this as-is would work.

Indeed, however I'd much rather have you rename to a less-generic name which has less risk of clashing or causing confusion.

[am11]

@lildude, agreed; that was my first preference as well. I will update the PR when the repo is renamed.

[Nixinova]

Okay, fine, renamed my repo

[Nixinova]

I had changed the repo name again to Nova.tmLanguage while you were doing this.

[am11]

I had changed the repo name again to Nova.tmLanguage while you were doing this.

or

I changed my mind (at least) one hour later and renamed again

otherwise timestamps and passing CI make no sense

[Nixinova]

It was changed literally 10sec later. See above, at how Nixinova/NovaGrammars#5 is located above your commit.

[am11]

It was changed literally 10sec later. See above, at how Nixinova/Nova.tmLanguage#5 is located above your commit.

[Nixinova]

Not sure why you deleted your old comment as that would've been what happened.

[am11]

It was not relevant to your 10sec comment, which I read after the page refresh. The difference was one hour not 10 sec.

[lildude]

@am11 would you mind updating this PR for the final new repo name?

[lildude]

I think you need to pull master into your branch as you appear to be missing the NimLime grammar change just merged.

[lildude]

Lovely! Thanks all. 🙇