Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clarity support #5665

Merged
merged 5 commits into from Feb 9, 2022
Merged

Add Clarity support #5665

merged 5 commits into from Feb 9, 2022

Conversation

agraebe
Copy link
Contributor

@agraebe agraebe commented Nov 29, 2021

Adding support for the Clarity Smart Contract language

Checklist:

@agraebe agraebe requested a review from a team as a code owner November 29, 2021 21:48
@Alhadis Alhadis changed the title feat: add Clarity support Add Clarity support Nov 29, 2021
@lildude
Copy link
Member

lildude commented Nov 30, 2021

Usage isn't quite there yet:

Total files found: 1315
Unique public user/repos: 170
Unique owners: 117

@Alhadis
Copy link
Collaborator

Alhadis commented Nov 30, 2021

Unique public user/repos

I realised earlier that saying "unique user/repos" is redundant, since a repository can't logically be owned by more than one user. Perhaps we can simplify our docs by counting users only?

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the test failure

@lildude
Copy link
Member

lildude commented Nov 30, 2021

I realised earlier that saying "unique user/repos" is redundant, since a repository can't logically be owned by more than one user. Perhaps we can simplify our docs by counting users only?

I've been using this to allow for a bit more flexibility as it allows users to have multiple repos, with the added unique users hinting at if there's a few users disproportionately contributing to the total repos.

@agraebe
Copy link
Contributor Author

agraebe commented Dec 1, 2021

Usage isn't quite there yet:

Total files found: 1315 Unique public user/repos: 170 Unique owners: 117

Thanks for sharing! Is there a way to run this analysis on my end? I tried Harvester but hitting this issue: Alhadis/Harvester#17 (comment)

@agraebe
Copy link
Contributor Author

agraebe commented Dec 27, 2021

@lildude could you please run the analysis again? and if you could help me with guidance on how to run it on my own, that'd be great.

thanks!

@agraebe agraebe requested a review from lildude January 4, 2022 21:11
@lgalabru
Copy link

lgalabru commented Jan 5, 2022

@lildude in parallel, we're also working on updating the Clarity LSP (https://github.com/hirosystems/clarity-lsp), to make it compatible with https://github.dev, and being on linguist would already be a great addition!
Any change you could give us the new numbers? Thank you so much for your help.

@lildude
Copy link
Member

lildude commented Jan 7, 2022

I'm not performing reviews of PRs or popularity checking until I've got the time to start working on the next release (likely to be in early Feb at the earliest).

@jdbender66
Copy link

jdbender66 commented Jan 25, 2022

@lildude Any update on the total count of Clarity :user/:repo? We had a lot of activity over the holidays and think we should be past the 200 threshold needed for inclusion in Linguist.

@chiedo chiedo mentioned this pull request Feb 3, 2022
9 tasks
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this based on the temporary requirements detailed in #5756

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, looks like we've got CI failures that need addressing first.

@lildude
Copy link
Member

lildude commented Feb 9, 2022

Whoops, looks like we've got CI failures that need addressing first.

Fixed it.

@lildude lildude merged commit c5c0a4d into github-linguist:master Feb 9, 2022
@jdbender66
Copy link

@lildude Hey there! Thanks so much for approving these changes and merging Clarity into Linguist.

Any idea if/when Clarity will be picked up by some of Github's features?

Wondering if Clarity will show up in the language dropdown for advanced search:
Screen Shot 2022-02-10 at 10 34 36 AM

Also, in the code breakdown sidebar when viewing a repo:
Screen Shot 2022-02-10 at 10 35 39 AM

Thanks! Curious if there is delay with automation.

@lildude
Copy link
Member

lildude commented Feb 10, 2022

Nothing will appear on GitHub until I've made a new Linguist release which I'll probably do next week or early the week after, depending on my workload.

This will however only affect language classification, syntax highlighting and the colourful bar in the sidebar. Search will only gain support when go-enry is updated to pull in the changes in the next Linguist release and then you'll need to wait for our Search team to update the version of go-enry Search uses to pull in those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants