New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clarity support #5665
Add Clarity support #5665
Conversation
Usage isn't quite there yet: Total files found: 1315 |
I realised earlier that saying "unique user/repos" is redundant, since a repository can't logically be owned by more than one user. Perhaps we can simplify our docs by counting users only? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the test failure
I've been using this to allow for a bit more flexibility as it allows users to have multiple repos, with the added unique users hinting at if there's a few users disproportionately contributing to the total repos. |
Thanks for sharing! Is there a way to run this analysis on my end? I tried Harvester but hitting this issue: Alhadis/Harvester#17 (comment) |
@lildude could you please run the analysis again? and if you could help me with guidance on how to run it on my own, that'd be great. thanks! |
@lildude in parallel, we're also working on updating the Clarity LSP (https://github.com/hirosystems/clarity-lsp), to make it compatible with https://github.dev, and being on linguist would already be a great addition! |
I'm not performing reviews of PRs or popularity checking until I've got the time to start working on the next release (likely to be in early Feb at the earliest). |
@lildude Any update on the total count of Clarity :user/:repo? We had a lot of activity over the holidays and think we should be past the 200 threshold needed for inclusion in Linguist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this based on the temporary requirements detailed in #5756
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, looks like we've got CI failures that need addressing first.
Fixed it. |
@lildude Hey there! Thanks so much for approving these changes and merging Clarity into Linguist. Any idea if/when Clarity will be picked up by some of Github's features? Wondering if Clarity will show up in the language dropdown for advanced search: Also, in the code breakdown sidebar when viewing a repo: Thanks! Curious if there is delay with automation. |
Nothing will appear on GitHub until I've made a new Linguist release which I'll probably do next week or early the week after, depending on my workload. This will however only affect language classification, syntax highlighting and the colourful bar in the sidebar. Search will only gain support when go-enry is updated to pull in the changes in the next Linguist release and then you'll need to wait for our Search team to update the version of go-enry Search uses to pull in those changes. |
Adding support for the Clarity Smart Contract language
Checklist:
.clar
extension