Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile Updates #6066

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Dockerfile Updates #6066

merged 1 commit into from
Sep 14, 2022

Conversation

jonpulsifer
Copy link
Contributor

This PR does not introduce any changes to installed packages, but it does change the filesystem by deleting the package caches.

  • The linux-headers package is found in the base image, such that adding it is not required
  • The removal of build-base, libc-dev, and cmake are handled by apk del build_deps, the virtual package we created. linux-headers can not be deleted, as it is required by libffi-dev in the base image.
  • Removing --no-cache on the second apk add because the package caches were already downloaded and retained in the first apk add, so there's no need to fetch them again.
  • Removing the caches from /var/cache/apk/* saves some mega bees 🐝

This PR does not introduce any changes to installed packages, but it does change the filesystem by deleting the package caches.

- The `linux-headers` package is found in the base image, such that adding it is not required
- The removal of `build-base`, `libc-dev`, and `cmake` are handled by `apk del build_deps`, the virtual package we created. `linux-headers` can not be deleted, as it is required by `libffi-dev` in the base image.
- Removing `--no-cache` on the second `apk add` because the package caches were already downloaded and retained in the first `apk add`, so there's no need to fetch them again.
- Removing the caches from `/var/cache/apk/*` saves some KBees 🐝
@jonpulsifer jonpulsifer marked this pull request as ready for review September 14, 2022 15:31
@jonpulsifer jonpulsifer requested a review from a team as a code owner September 14, 2022 15:31
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this.

@lildude lildude merged commit f3f2103 into github-linguist:master Sep 14, 2022
@jonpulsifer jonpulsifer deleted the update-dockerfile branch September 14, 2022 20:07
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants