Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language Just / Justfile #6086

Merged
merged 21 commits into from
Oct 20, 2022
Merged

Add language Just / Justfile #6086

merged 21 commits into from
Oct 20, 2022

Conversation

mihaigalos
Copy link
Contributor

@mihaigalos mihaigalos commented Sep 19, 2022

Description

This PR adds language support for just.

Checklist:

@mihaigalos mihaigalos changed the title Feat/support/justfile Add language: Just / Justfile Sep 19, 2022
@casey
Copy link
Contributor

casey commented Sep 20, 2022

I'm the maintainer of just, and just wanted to note that this looks good to me. Let me know if I can be of assistance!

@mihaigalos mihaigalos marked this pull request as ready for review September 20, 2022 05:16
@mihaigalos mihaigalos requested a review from a team as a code owner September 20, 2022 05:16
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

We also need the cached license file from the grammar which should have been downloaded when you ran script/add-grammar. If you can't find it or it wasn't for some reason, you can get it again by running: bundle exec licensed cache -c vendor/licenses/config.yml.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
@mihaigalos mihaigalos marked this pull request as draft September 21, 2022 16:17
@mihaigalos mihaigalos marked this pull request as ready for review September 22, 2022 05:39
lib/linguist/languages.yml Outdated Show resolved Hide resolved
grammars.yml Outdated Show resolved Hide resolved
@lildude lildude changed the title Add language: Just / Justfile Add Just / Justfile Oct 19, 2022
@lildude lildude changed the title Add Just / Justfile Add language Just / Justfile Oct 19, 2022
lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
grammars.yml Outdated Show resolved Hide resolved
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the samples/Justfile/ directory which contains your sample to samples/just/

You'll also need to run list-grammars again and correct the ordering to resolve the last of the test failures.

@lildude lildude merged commit 418be6a into github-linguist:master Oct 20, 2022
@mihaigalos mihaigalos deleted the feat/support/justfile branch October 20, 2022 12:28
@mihaigalos
Copy link
Contributor Author

mihaigalos commented Oct 20, 2022

Hey @lildude, thank you for your support in getting this PR merged. 👍
Is the syntax coloring taking effect immediately or does GH need to reindex something?

Up: I reread the CONTRIBUTING.md, I guess that answers it! 😅:

New languages will not appear in GitHub's search results for some time after the pull request has been merged and the new Linguist release deployed to GitHub.com.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants